search

akamai / cli-cps

Provides a way to interact with the Akamai Certificate Provisioning System (CPS) via Open APIs. Provides various functionality such as viewing certificate details, generating audits, checking change statuses, and creating/modifying certificates.
Apache License 2.0
14 stars 16 forks source link

adding python 2 check #18

Closed aalquist closed 4 years ago

aalquist commented 6 years ago

confirm the CLI tool has picked the correct python runtime (version 3) before proceeding

vreddhi commented 6 years ago

@aalquist Thanks for this commit. Is this tested on a machine or pyenv where python2 is installed?

aalquist commented 6 years ago

I tested on my machine with python 3 for positive test case. I only tested the main file on a python 2 machine. Can you help me confirm?

vreddhi commented 5 years ago

@aalquist This didnt work for me in a python2 machine. I suspect the reason to be the syntax used for print statement.

There is a syntax change for function calls between python2 and python3. Here you are checking the version to be lesser than 3, and if it is true we should invole print statement with python2's print statement syntax.

rajiv commented 5 years ago

the create-dns functionality should be split out into a separate PR from checking for python 2.

vreddhi commented 5 years ago

This merge request has too many changes. Also, we dont need proxy support per-package basis as CLI module should take care of it. The SPS API integration can wait as we have HAPI and PAPI releasing features/new api endpoints soon.

aetsai commented 4 years ago

python2 eol 2020