akamai / cli-firewall

Provides a way to interact with Firewall Rules and Site Shield related information via Open APIs.
Apache License 2.0
15 stars 9 forks source link

Document --edgerc and --section parameters in help #10

Closed javiergarza closed 4 years ago

javiergarza commented 5 years ago

It will be great if the cli-firewall would be consistent with the rest of Akamai CLI packages and would allow the --edgerc flag to allow indicating the file containing the edgegrid credentials and --section flag to allow indicating the .edgerc section to use

vreddhi commented 5 years ago

It should already support both. I see it working.

javiergarza commented 5 years ago

OK, fair enough. 1) Can you please include those 2 parameters in the online help? 2) In the other CLI packages those parameters are indicated after the package name, but in the fw package the command seems to fail when you indicate --edgerc or --section before the command (see second command below)

$ akamai fw help usage: akamai firewall help [command] [--version] ...

Akamai CLI for Firewall Rules

optional arguments: --version show program's version number and exit

Commands:

help              Show available help
list-services     List all firewall rules services available
list-subscriptions
                  List current subscriptions
subscribe         Subscribe to a firewall rules service
unsubscribe       Unsubscribe from a firewall rules service
list-cidrs        List the CIDRs for current subscription or a specific
                  firewall rules service

$ akamai fw --section dac-open help usage: akamai firewall [--version] ... akamai firewall: error: argument : invalid choice: 'dac-open' (choose from 'help', 'list-services', 'list-subscriptions', 'subscribe', 'unsubscribe', 'list-cidrs')

aetsai commented 4 years ago

closed in v0.2.0