search

akamaster / pytorch_resnet_cifar10

Proper implementation of ResNet-s for CIFAR10/100 in pytorch that matches description of the original paper.
BSD 2-Clause "Simplified" License
1.22k stars 335 forks source link

Fix typo #15

Closed MarisaKirisame closed 3 years ago

p16i commented 4 years ago

There seem to be two typos in the declaration of CLI arguments.

  1. Line 40-41 
    parser.add_argument('--weight-decay', '--wd', default=1e-4, type=float,
                metavar='W', help='weight decay (default: 5e-4)')

    The actual value is 1e-4 but what written in the help is 5e-4.

  2. Line 42 
    parser.add_argument('--print-freq', '-p', default=50, type=int,
                metavar='N', help='print frequency (default: 20)')

    Similar issue as above.

IMHO, we can fix them in this PR. @MarisaKirisame what do you think?

akamaster commented 3 years ago

@MarisaKirisame @heytitle Thanks a lot for your comments. I think some of the issues were fixed, but not all. If you are willing to change/update your pull request this will be amazing! @heytitle, if @MarisaKirisame is not going to change the pull request, are you willing to create your own?

MarisaKirisame commented 3 years ago

@akamaster hi, I had fixed them.