search

akamensky / argparse

Argparse for golang. Just because `flag` sucks
MIT License
604 stars 62 forks source link

Add support for integer arguments #10

Closed jsullivan3 closed 6 years ago

jsullivan3 commented 6 years ago

Integer arguments seem to have been an oversight. This PR adds support for processing integer arguments, as well as tests to verify the correct operation of integer argument processing.

akamensky commented 6 years ago

Also before I can merge it, can you please squash all commits to one. That would be very helpful!

jsullivan3 commented 6 years ago

Will squash as requested - not a problem. And thank you for this fantastic Go package. It allowed me to greatly improve the usability of the CLIs that I'm writing.

jsullivan3 commented 6 years ago

I think the current squashed commit covers all the changes requested - please let me know if you have any other feedback and I'll gladly implement it. Thanks again for your time in reviewing this change.

akamensky commented 6 years ago

And thank you for this PR!

jsullivan3 commented 6 years ago

Awesome - you are very welcome!