search

akamensky / argparse

Argparse for golang. Just because `flag` sucks
MIT License
611 stars 62 forks source link

Rename getter fields without Get prefix #74

Closed tonimelisma closed 3 years ago

tonimelisma commented 3 years ago

According to Effective Go getter methods should be named based on the object and shouldn't include the get prefix.

akamensky commented 3 years ago

I think it is a good idea to follow with standards where they make sense.

Welcome to send a PR for this if you would like to. However please keep in mind backward compatibility promise. Which means renames can only be done for internal methods.

On the other hand it would be a good idea to follow that in v2 of this library whenever that happens.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs. Thank you for your contributions. Feel free to comment or otherwise update to keep it alive.

tonimelisma commented 3 years ago

In-line with the bot comment, here's a placeholder comment to verify this issue is in no way stale.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs. Thank you for your contributions. Feel free to comment or otherwise update to keep it alive.

stale[bot] commented 3 years ago

Closing due to old age. Feel free to re-open or ping maintainers.