akamhy / videohash

Near Duplicate Video Detection (Perceptual Video Hashing) - Get a 64-bit comparable hash-value for any video.
https://pypi.org/project/videohash
MIT License
281 stars 46 forks source link

Videohash 'is_similar' function returns True for different videos #101

Open steph-ieffam opened 1 year ago

steph-ieffam commented 1 year ago

BUG REPORT the videohash function is_similar returns True even when the videos are different.

NOTES: One thing I noticed is that the is_similar function seems to be not correctly implemented. Basically this function sometimes returns True even though videos are completely different. I expect the is_similar function to return True for videos that at least shares some common characteristics as video length for example.

How are two videos supposed to be the equal if their length is not even similar? I would add a check prior than generating the hash value.

So, the videohash code should also take video length in consideration when comparing two videos for similarities