Closed eggplants closed 2 years ago
Hello @eggplants! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
waybackpy/cdx_api.py
:Line 38:80: E501 line too long (88 > 79 characters) Line 39:80: E501 line too long (82 > 79 characters) Line 42:80: E501 line too long (81 > 79 characters)
waybackpy/cli.py
:Line 26:13: W503 line break before binary operator Line 26:80: E501 line too long (80 > 79 characters) Line 27:13: W503 line break before binary operator Line 28:13: W503 line break before binary operator Line 28:80: E501 line too long (80 > 79 characters) Line 42:80: E501 line too long (83 > 79 characters) Line 294:80: E501 line too long (84 > 79 characters) Line 298:80: E501 line too long (84 > 79 characters) Line 302:80: E501 line too long (84 > 79 characters)
waybackpy/wrapper.py
:Line 21:80: E501 line too long (82 > 79 characters) Line 24:80: E501 line too long (81 > 79 characters)
I am resolving the conflict. Your names are better than mine and are also typed.
Oops, overlooked #132. Sorry!
Does pep8speaks ignore flake8 configuration in setup.cfg?
max-line-length = 88
in setup.cfg, but @pep8speaks says >77
.
Does pep8speaks ignore flake8 configuration in setup.cfg?
max-line-length = 88
in setup.cfg, but77
in pep8speaks.
It is not supposed to ignore it as per the 2nd last point in https://github.com/OrkoHunter/pep8speaks#configuration. Let me push a .pep8speaks.yml
into the master with flask8
in scanner.linter
.
OK, Please try it.
OK, Please try it.
Should be fixed in https://github.com/akamhy/waybackpy/commit/9d9cc3328b6c43b3915017434c48470134a98bad and it should now respect the setting in setup.cfg
I refactored codes to decrease complexity. 4df8364a1a69e1c920bc77260098be09a87ddcdb
None
instead of[]
as default paramno-value-for-parameter