search

akamhy / waybackpy

Wayback Machine API interface & a command-line tool
https://pypi.org/project/waybackpy/
MIT License
484 stars 33 forks source link

add sort param support in CDX API class #156

Closed akamhy closed 2 years ago

akamhy commented 2 years ago

see https://nla.github.io/outbackcdx/api.html#operation/query

sort takes string input which must be one of the follwoing:

This commit shall help in closing issue at https://github.com/akamhy/waybackpy/issues/155

codecov[bot] commented 2 years ago

Codecov Report

Merging #156 (b4adf4a) into master (f63c6ad) will decrease coverage by 0.04%. The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   94.24%   94.19%   -0.05%     
==========================================
  Files          10       10              
  Lines         608      620      +12     
==========================================
+ Hits          573      584      +11     
- Misses         35       36       +1
Impacted Files Coverage Δ
waybackpy/cdx_api.py 89.62% <75.00%> (-0.58%) :arrow_down:
waybackpy/cdx_utils.py 98.61% <100.00%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f63c6ad...b4adf4a. Read the comment docs.

akamhy commented 2 years ago

Ignoring the coverage for now as it should be ok after we add the near, newest, and oldest methods in the CDX class along with the tests.