Closed akamhy closed 2 years ago
Hello @akamhy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
tests/test_cli.py
:Line 115:9: W503 line break before binary operator
waybackpy/cdx_api.py
:Line 233:17: W503 line break before binary operator Line 234:17: W503 line break before binary operator Line 235:17: W503 line break before binary operator
waybackpy/cli.py
:Line 399:13: W503 line break before binary operator Line 400:13: W503 line break before binary operator Line 467:13: W503 line break before binary operator Line 468:13: W503 line break before binary operator
Hello @akamhy! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
waybackpy/cdx_api.py
:Line 233:17: W503 line break before binary operator Line 234:17: W503 line break before binary operator Line 235:17: W503 line break before binary operator
- In the file
waybackpy/cli.py
:Line 399:13: W503 line break before binary operator Line 400:13: W503 line break before binary operator Line 467:13: W503 line break before binary operator Line 468:13: W503 line break before binary operator
WTH
Merging #159 (d6341aa) into master (f990b93) will increase coverage by
0.00%
. The diff coverage is90.47%
.
@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 95.45% 95.46%
=======================================
Files 10 10
Lines 638 661 +23
=======================================
+ Hits 609 631 +22
- Misses 29 30 +1
Impacted Files | Coverage Δ | |
---|---|---|
waybackpy/cli.py | 94.64% <76.92%> (-0.66%) |
:arrow_down: |
waybackpy/availability_api.py | 98.64% <100.00%> (-0.11%) |
:arrow_down: |
waybackpy/cdx_api.py | 93.89% <100.00%> (+1.30%) |
:arrow_up: |
waybackpy/cdx_snapshot.py | 100.00% <100.00%> (ø) |
|
waybackpy/exceptions.py | 100.00% <100.00%> (ø) |
|
waybackpy/utils.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f990b93...d6341aa. Read the comment docs.
Availability API is too unreliable for use when compared with the CDX server API.
Merging this PR closes #155