search

akamhy / waybackpy

Wayback Machine API interface & a command-line tool
https://pypi.org/project/waybackpy/
MIT License
462 stars 34 forks source link

No need to fetch archive_url and timestamp from availability API on init #55

Closed akamhy closed 3 years ago

akamhy commented 3 years ago

Not useful if all I want is archiving an URL. This should never make request to availability API.

codecov[bot] commented 3 years ago

Codecov Report

Merging #55 (ee21b80) into master (0b71433) will decrease coverage by 9.21%. The diff coverage is 48.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   93.28%   84.07%   -9.22%     
==========================================
  Files           5        5              
  Lines         298      339      +41     
==========================================
+ Hits          278      285       +7     
- Misses         20       54      +34
Impacted Files Coverage Δ
waybackpy/cli.py 83.23% <30.30%> (-12.60%) :arrow_down:
waybackpy/wrapper.py 83.66% <66.66%> (-6.42%) :arrow_down:
waybackpy/__version__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b71433...2e41b77. Read the comment docs.

pep8speaks commented 3 years ago

Hello @akamhy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 32:89: E501 line too long (107 > 88 characters)

Comment last updated at 2021-01-02 05:39:57 UTC