Closed akamhy closed 3 years ago
Hello @akamhy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
waybackpy/cdx.py
:Line 14:89: E501 line too long (89 > 88 characters)
waybackpy/snapshot.py
:Line 40:89: E501 line too long (106 > 88 characters)
waybackpy/utils.py
:Line 110:89: E501 line too long (91 > 88 characters)
waybackpy/wrapper.py
:Line 87:89: E501 line too long (106 > 88 characters)
Merging #90 (31e3eae) into master (88cda94) will decrease coverage by
0.17%
. The diff coverage is87.50%
.
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 91.11% 90.94% -0.18%
==========================================
Files 8 8
Lines 563 563
==========================================
- Hits 513 512 -1
- Misses 50 51 +1
Impacted Files | Coverage Δ | |
---|---|---|
waybackpy/cdx.py | 94.80% <ø> (ø) |
|
waybackpy/cli.py | 94.44% <ø> (ø) |
|
waybackpy/snapshot.py | 100.00% <ø> (ø) |
|
waybackpy/wrapper.py | 82.78% <71.42%> (-0.14%) |
:arrow_down: |
waybackpy/utils.py | 89.80% <94.11%> (-0.58%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 88cda94...31e3eae. Read the comment docs.
Added doc strings in all files in waybackpy dir except CLI as we still need to add features in CLI.