Currently, the constructor of HaveIBeenPwnedClient only accepts a ClientSettings object because it needs to pass it on to HttpServiceClient. We can safely remove it from HaveIBeenPwnedClient and if a user wants to override the defaults they can instantiate HttpServiceClient themselves and use constructor injection to pass that client to HaveIBeenWPnedClient.
We should also move ClientSettings to the AtleX.HaveIBeenPwned.Communication.Http namespace and consider renaming it to HttpClientSettings.
Currently, the constructor of
HaveIBeenPwnedClientonly accepts aClientSettingsobject because it needs to pass it on toHttpServiceClient. We can safely remove it fromHaveIBeenPwnedClientand if a user wants to override the defaults they can instantiateHttpServiceClientthemselves and use constructor injection to pass that client toHaveIBeenWPnedClient.We should also move
ClientSettingsto theAtleX.HaveIBeenPwned.Communication.Httpnamespace and consider renaming it toHttpClientSettings.