akamsteeg / AtleX.HaveIBeenPwned

A fully async .NET Standard client library for the API of HaveIBeenPwned.com
https://www.nuget.org/packages/AtleX.HaveIBeenPwned/
MIT License
5 stars 0 forks source link

Mark KAnonimityHelper as internal and move it to the AtleX.HaveIBeenPwned.Clients.Http namespace #18

Closed akamsteeg closed 5 years ago

akamsteeg commented 5 years ago

The KAnonimityHelper is currently public but it's quite tightly coupled to the HttpHaveIBeenPwnedClient. It's most likely of limited use outside of it, since any custom IHaveIBeenPwnedClient will probably work differently otherwise the user would have used the HttpHaveIBeenPwnedClient. So, we should reduce the API surface of the lib by making internal stuff internal

Suggestion: Mark KAnonimityHelper helper as internal and move it to the AtleX.HaveIBeenPwned.Clients.Http(.Helpers?) namespace