akamsteeg / AtleX.HaveIBeenPwned

A fully async .NET Standard client library for the API of HaveIBeenPwned.com
https://www.nuget.org/packages/AtleX.HaveIBeenPwned/
MIT License
5 stars 0 forks source link

HttpHaveIBeenPwnedClient.GetBreachesInternalAsync(string, BreachMode, CancellationToken) returns null instead of an empty enumerable when no data was loaded #23

Closed akamsteeg closed 5 years ago

akamsteeg commented 5 years ago

HttpHaveIBeenPwnedClient.GetBreachesInternalAsync(string, BreachMode, CancellationToken) returns null instead of an empty enumerable when no data was loaded. That leads to bugs on the call site because people are expecting to be able to use LINQ or something like that to search in the returned collection. Also, GetPastesInternalAsync(string, CancellationToken) does correctly return an empty enumerable so we're inconsistent now.