Closed akamsteeg closed 4 years ago
I decided to hold off on using ValueTask
/ValueTask<T>
. I realize its benefits, but currently we would introduce a new dependency for NETFX and that's not worth the risk I think. Especially when the benefits for NETFX are questionable right now and we have a lot of looooooooong-running things going out of process (calling the HaveIBeenPwned.com API). Is it worth using ValueTask
/ValueTask<T>
right now? I think it just complicates matters so I'll wait.
We should try to switch to C#8 with Nullable Reference Types for this lib:
Tasks:
!is
, etc. Leave the argument checking intact. We must guarantee that we don't break things on NETFX. Keep in mind that using some things from the internal API might bubble through to the public API;(See https://github.com/akamsteeg/AtleX.HaveIBeenPwned/issues/31#issuecomment-534633024)ValueTask<T>
internally, where applicable. This is a hard one. Any TFM above .NET Standard 2.0 is not a good idea right now. We want to support a wide range of TFM's (.NET 4.7.2+, .NET Standard 2.0+) and that precludes the usage ofValueTask<T>
currently.