akamsteeg / AtleX.HaveIBeenPwned

A fully async .NET Standard client library for the API of HaveIBeenPwned.com
https://www.nuget.org/packages/AtleX.HaveIBeenPwned/
MIT License
5 stars 0 forks source link

Switch to C#8 and use Nullable Reference Types annotations #31

Closed akamsteeg closed 4 years ago

akamsteeg commented 5 years ago

We should try to switch to C#8 with Nullable Reference Types for this lib:

Tasks:

akamsteeg commented 4 years ago

I decided to hold off on using ValueTask/ValueTask<T>. I realize its benefits, but currently we would introduce a new dependency for NETFX and that's not worth the risk I think. Especially when the benefits for NETFX are questionable right now and we have a lot of looooooooong-running things going out of process (calling the HaveIBeenPwned.com API). Is it worth using ValueTask/ValueTask<T> right now? I think it just complicates matters so I'll wait.