This is used in HaveIBeenPwnedClient to set a timeout on the HttpClient that gets injected or instantiated by HaveIBeenPwnedClient itself.
This is a bit of a confusing API for several reasons:
The user might have passed on a HttpClient which is already fully configured with a timeout, and then the configured timeout is overwritten by the value configured in HaveIBeenPwnedClientSettings.TimeOut;
When the user configures a timeout on the HttpClientand specifies a value on HaveIBeenPwnedClientSettings.TimeOut, the latter 'wins' but this isn't clear to the user.
I suggest marking HaveIBeenPwnedClientSettings.TimeOut as with an ObsoleteAttribute and ignore any value assigned to it from now on.
In
HaveIBeenPwnedClientSettingsthere's aTimeOutproperty:https://github.com/akamsteeg/AtleX.HaveIBeenPwned/blob/a00a6ce3bd98e3d95d1d445bfa83ede97710c976/src/AtleX.HaveIBeenPwned/HaveIBeenPwnedClientSettings.cs#L26
This is used in
HaveIBeenPwnedClientto set a timeout on theHttpClientthat gets injected or instantiated byHaveIBeenPwnedClientitself.This is a bit of a confusing API for several reasons:
HttpClientwhich is already fully configured with a timeout, and then the configured timeout is overwritten by the value configured inHaveIBeenPwnedClientSettings.TimeOut;HttpClientand specifies a value onHaveIBeenPwnedClientSettings.TimeOut, the latter 'wins' but this isn't clear to the user.I suggest marking
HaveIBeenPwnedClientSettings.TimeOutas with anObsoleteAttributeand ignore any value assigned to it from now on.