akamsteeg / AtleX.HaveIBeenPwned

A fully async .NET Standard client library for the API of HaveIBeenPwned.com
https://www.nuget.org/packages/AtleX.HaveIBeenPwned/
MIT License
5 stars 0 forks source link

Remove SerializableAttribute from exceptions #50

Closed akamsteeg closed 2 years ago

akamsteeg commented 3 years ago

Right now, HaveIBeenPwnedClientException and anything that inherits from it are marked with a SerializableAttribute. This is mainly used for binary serialization, which we really shouldn't use anymore. (See the excellent presentation Are you not my type?)

Suggestion, drop the SerializableAttribute from all exceptions.