akamsteeg / AtleX.HaveIBeenPwned

A fully async .NET Standard client library for the API of HaveIBeenPwned.com
https://www.nuget.org/packages/AtleX.HaveIBeenPwned/
MIT License
5 stars 0 forks source link

Standardize IEquatable<T> implementations #52

Closed akamsteeg closed 3 years ago

akamsteeg commented 3 years ago

In #46, we implemented IEquatable<T> on Breach, Paste and SiteBreach. Each of these classes have their own implementations, so if we need to change things we need to revisit all three classes with the risk that we forget one.

Suggestion: Introduce a helper for equality operations.

akamsteeg commented 3 years ago

Improved in d64ca11a