search

akamsteeg / AtleX.HaveIBeenPwned

A fully async .NET Standard client library for the API of HaveIBeenPwned.com
https://www.nuget.org/packages/AtleX.HaveIBeenPwned/
MIT License
5 stars 0 forks source link

Run tests and benchmarks on currently supported LTS frameworks only #59

Closed akamsteeg closed 2 years ago

akamsteeg commented 2 years ago

At this time, .NET 4,8, .NET Core 3.1 and .NET 6 are currently supported LTS releases. We want to run the unit tests, integration tests and benchmarks only against those frameworks.

Running tests & benchmarks on obsolete TFMs is causing a burden for maintenance since they're no longer available with new VS2022 installs and on the build agents. And I am fairly confident that as long as we target .NET Standard 2.0 and run our tests against those three current LTS releases the library will work on for example .NET Core 2.1 too.

FYI: At some point in the the past we specifically ran tests against .NET 4.6.1/4.6.2 too because of the broken .NET Standard support in there. Those versions are now ancient (8 years) and we're not spending any effort on verifying the lib still works on those old TFMs anymore. You can be fairly certain that version 5.0.0 works on .NET 4.6.2 though.

akamsteeg commented 2 years ago

Fixed in 568bb3c66b7b64ad3ab144565686ebb44cbf3b3c.