akamud / vscode-theme-onedark

VSCode Theme based on Atom's One Dark theme
MIT License
285 stars 196 forks source link

Compatibility Issue with "Jupyter" VS Code Extension #104

Open sebastian-nunez opened 5 years ago

sebastian-nunez commented 5 years ago

So, I downloaded the Jupyter extension for VS Code and ran the "sample" code the Jupyter extension provides; unfortunately, I quickly noticed that one I executed the cell, there were some color issues with the "=" and the plot itself. In the end, I decided to run a test and see if the issue was Jupyter or Atom One Dark theme. So, I switched my theme to the stock VS Code light theme and thruth be told, the plot was "normal" (in respect to the theme).

Sample code

#%%
import matplotlib.pyplot as plt
import matplotlib as mpl
import numpy as np

x = np.linspace(0, 20, 100)
plt.plot(x, np.sin(x))
plt.show()

Extension and Language selected

Light+ (default light)

atombug1

Atom One Dark

atombug

Versions used

Extra information

In the end, I think the plot background should match up with the rest of the editor. Thank you.

sebastian-nunez commented 5 years ago

Default Markdown Preview Color Issue (similar to issue #104)

I'm not really sure if this's intended or not, but while using the default VS Code Markdown previewer, I found some color discrepancies with the code blocks. In brief, similar to the Jupyter issue above, the code block preview shows up in a very off-putting color (not at all like the general Atom One Dark color scheme). So, I'm not really sure if anything can be done about it. Also, I noticed that the checkmark boxes were blending a little bit into the background color of the editor, so, I don't know if there's a way to adjust the color and make them more suitable for the Dark Theme.

Screenshot

atombug