editor.renderWhitespace doesn't work

akamud / vscode-theme-onedark

VSCode Theme based on Atom's One Dark theme

MIT License

286 stars 196 forks source link

editor.renderWhitespace doesn't work #121

Closed AlencarGabriel closed 4 years ago

AlencarGabriel commented 4 years ago

Sample code

any code

Filename and Language selected

not applicable

Atom Original theme Screenshot

VSCode theme Screenshot

Versions used

VSCode version: 1.43.0
Theme version: 2.1.0

Extra information

In version 1.43.0 of VsCode, the editor.renderWhitespace: selection configuration was made available. But apparently the rendering of the TAB and space characters isn't being done in this theme.

AlencarGabriel commented 4 years ago

I was wrong. It's actually being rendered. But the color of the rendered elements is very close to the background of the code selection.

Should this treatment be done in the theme?

akamud commented 4 years ago

This is now fixed in 2.2.0.

Please remember to disable Semantic Highlighting if you are using VSCode 1.43.0:

"editor.semanticHighlighting.enabled": false

AlencarGabriel commented 4 years ago

Thanks for quick fix!