search

akamud / vscode-theme-onedark

VSCode Theme based on Atom's One Dark theme
MIT License
293 stars 200 forks source link

colors seems washed out #126

Open mcanepa opened 4 years ago

mcanepa commented 4 years ago

I've decided to give visual studio code a try. I'm running v1.45.1 on a Debian 9 with gnome

Version: 1.45.1
Commit: 5763d909d5f12fe19f215cbfdd29a91c0fa9208a
Date: 2020-05-14T08:27:22.494Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 4.9.0-12-amd64

Sample code

//PHP
<?php
error_reporting(E_ALL ^ E_NOTICE);
ini_set("display_errors", 1);

namespace my\Code;

use vendor\Something\SomeClass;

define("MY_CONST", 12345);

class MyClass
{
    function getSomething($param = [])
    {
        $my_array = [
            "keyA" => 123,
            "keyB" => "string",
        ];

        return $my_array;
    }
}

$objMyClass = new MyClass();

$execute = $objMyClass->getSomething();

//JS
var MyObj = {};

MyObj.customObject = {
    "id" : 123,
    "text" : null
};

MyObj.myFunction = function()
{
    var copy = JSON.clone(MyObj.x);

    copy.keyNum = 123;
    copy.keyStr = "hello";

    $("selector").text("test");

    var deferred = new $.Deferred();

    deferred.resolve();

    return deferred.promise();
}

//HTML
<!DOCTYPE html>
<html>
    <head>
        <title>Title</title>
        <meta http-equiv="content-type" content="text/html; charset=UTF-8">
        <link rel="stylesheet" type="text/css" href="css/style.css">
        <script type="text/javascript" src="js/jquery.js"></script>
    </head>
    <body>
        <div>
            <p>hello</p>
        </div>
    </body>
</html>

[Please tell us which file extension are you editing and which language VSCode is using for this file]

Atom Original theme Screenshot

atom

[Screenshot of your code inside Atom, under same conditions, showing how the coloring should look]

VSCode theme Screenshot

vsc_atom_one_dark

Versions used