akamud / vscode-theme-onedark

VSCode Theme based on Atom's One Dark theme
MIT License
283 stars 198 forks source link

Terminal colours? #127

Open amk221 opened 4 years ago

amk221 commented 4 years ago

I'm new to VS Code, so forgive me if this is out of the scope of your Extension. But shouldn't the terminal colours be onedark based too?

Thanks!

akamud commented 4 years ago

Thanks for bringing this to my attention, I guess I never thought much about it. I like the fact that it keeps my terminal theme intact, but it is totally doable from what I've seen in the docs.

I guess it makes sense to see what other people using the theme think. You could customize it yourself in the meantime though.

vanyauhalin commented 2 years ago

@amk221, a lot of time has passed, but:

"workbench.colorCustomizations": {
    "terminal.ansiBlack": "#181a1f",
    "terminal.ansiBlue": "#61afef",
    "terminal.ansiBrightBlack": "#5c6370",
    "terminal.ansiBrightBlue": "#61afef",
    "terminal.ansiBrightCyan": "#56b6c2",
    "terminal.ansiBrightGreen": "#98c379",
    "terminal.ansiBrightMagenta": "#c678dd",
    "terminal.ansiBrightRed": "#e06c75",
    "terminal.ansiBrightWhite": "#ffffff",
    "terminal.ansiBrightYellow": "#e5c07b",
    "terminal.ansiCyan": "#56b6c2",
    "terminal.ansiGreen": "#98c379",
    "terminal.ansiMagenta": "#c678dd",
    "terminal.ansiRed": "#e06c75",
    "terminal.ansiWhite": "#abb2bf",
    "terminal.ansiYellow": "#e5c07b",
    "terminal.background": "#282c34",
    "terminal.foreground": "#abb2bf",
    "terminal.selectionBackground": "#3e4451"
},

Unfortunately, the bright colors are no different from the usual.