search

akamud / vscode-theme-onedark

VSCode Theme based on Atom's One Dark theme
MIT License
283 stars 198 forks source link

ruby color inconsistent #137

Open lacostenycoder opened 3 years ago

lacostenycoder commented 3 years ago

The syntax highlight of key values in hashes is missing as well as many of the colors simply don't match at all.

Here's Atom colors atom

Here's the VSCode port version vscode_one_dark_ruby

Here also some regular expression syntax highlighting is missing as well as things like array constructor modifiers %i[:a, :b, :c]

Atom atom_regex

VSCode vscode_regex

akamud commented 3 years ago

Thanks for reporting this, I'll try to fix this in the next version.

collimarco commented 7 months ago

I love this theme, but many colors should be fixed in Ruby.

For example, hash keys and symbols should have a different color from numbers, otherwise it's really hard to read Ruby code. It would be great if you can fix this