akamud / vscode-theme-onelight

VSCode Theme based on Atom's One Light theme
MIT License
78 stars 54 forks source link

Adopt semantic highlighting #18

Open aeschli opened 4 years ago

aeschli commented 4 years ago

As I just filed for the One Dark theme, it would be great if also the One Light theme could adopt semantic highlighting.

The Semantic Highlighting Wiki and the Semantic Highlighting Guide have more details and please feel free to ping me in this issue if I can help.

s0kil commented 4 years ago

Looking forward to this!

s0kil commented 4 years ago

Related: https://github.com/akamud/vscode-theme-onedark/issues/124

lukepighetti commented 2 years ago

One Light is my favorite theme, but language servers are all adopting semantic highlighting. So this theme is being left behind. As this issue is 2 years old, I really hope that it will come around soon.

lukepighetti commented 2 years ago

Looks like the core theme hasn't been updated in 2 years, all recent updates are to add funding information to the project.

https://github.com/akamud/vscode-theme-onelight/commits/master/themes/OneLight.json