akamud / vscode-theme-onelight

VSCode Theme based on Atom's One Light theme
MIT License
79 stars 54 forks source link

Add missing "selectionHighlightBackground" key #27

Closed andreynering closed 2 years ago

andreynering commented 2 years ago

This is the key that highlights other identical words (those you can follow which command+D) when you select one.

The default was too close to white, almost invisible. Changing to a slightly darker grey.

andreynering commented 2 years ago

@akamud Closed without a comment?

akamud commented 2 years ago

Sorry about that. I just released a new version today and the original issue seems fixed. Can you confirm if this is correct or if I misunderstood the issue please?

andreynering commented 2 years ago

@akamud I just updated and the selection is still too light for me, too similar to white, hard to see.

And the selectionHighlightBackground key is still missing on the OneLight.json: https://raw.githubusercontent.com/akamud/vscode-theme-onelight/master/themes/OneLight.json

akamud commented 2 years ago

Can you please attach some screenshots? When I was testing the editor was using a dark color for me. Maybe I'm missing something.

andreynering commented 2 years ago

Before

Screen Shot 2022-10-14 at 15 48 34

After

Screen Shot 2022-10-14 at 15 48 53

As I said, I found it quite hard to see matched words. I'm using this on settings.json for now to override it:

{
  "workbench.colorCustomizations": {
    "[Atom One Light]": {
      "editor.selectionHighlightBackground": "#eaeaeb"
    }
  }
}