Workbench theming opt-in

[glambert]

Hi! First, thanks for your work on this theme. Been using it since I switched to VSCode and really enjoying it 👍

With the latest release you added the theming of the whole editor including the workbench, could that be optional? I'd really like to keep the rest of the theme with the default VSCode and only have the actual editor themed like before.

Thanks!

Versions used

• VSCode version: 1.12.2
• Theme version: 2.0.1

[akamud]

I'll have to check if VSCode allows this kind of scenario.

In the meantime, you can override all theming colors in your user settings with theses values:

"workbench.colorCustomizations": {
        "activityBarBadge.background": "#007ACC",
        "activityBarBadge.foreground": "#FFFFFF",
        "activityBar.background": "#2C2C2C",
        "activityBar.foreground": "#FFFFFF",
        "activityBar.border": "null",
        "editor.background": "#FFFFFF",
        "editor.foreground": "#000000",
        "editor.inactiveSelectionBackground": "#E5EBF1",
        "editorIndentGuide.background": "#D3D3D3",
        "editor.selectionHighlightBackground": "#ADD6FF4D",
        "editorSuggestWidget.background": "#F3F3F3",
        "editorGroup.background": "#ECECEC",
        "editorGroupHeader.tabsBackground": "#F3F3F3",
        "editorGroupHeader.tabsBorder": "null",
        "editorGroupHeader.noTabsBackground": "#FFFFFF",
        "editorGroup.border": "#E7E7E7",
        "sideBar.background" : "#F3F3F3",
        "sideBar.foreground": "null",
        "sideBar.border": "null",
        "sideBarTitle.foreground": "#6F6F6F",
        "sideBarSectionHeader.background": "#80808033",
        "sideBarSectionHeader.foreground": "null",
        "statusBar.foreground": "#FFFFFF",
        "statusBar.background": "#007ACC",
        "statusBar.border": "null",
        "statusBar.noFolderBackground": "#68217A",
        "statusBar.noFolderForeground": "#FFFFFF",
        "statusBarItem.hoverBackground": "#FFFFFF26",
        "statusBarItem.prominentBackground": "#388A34",
        "statusBarItem.prominentHoverBackground": "#369432",
        "tab.inactiveBackground": "#ECECEC",
        "tab.border": "#F3F3F3",
        "tab.activeForeground": "#333333",
        "titleBar.activeForeground" : "#333333",
        "titleBar.inactiveForeground": "#33333399",
        "titleBar.activeBackground": "#DDDDDD",
        "titleBar.inactiveBackground": "#DDDDDD99",
        "notification.foreground": "#EEEEEE",
        "notification.background": "#2C2C2C",
        "button.background": "#007ACC",
        "button.foreground": "#FFFFFF",
        "list.activeSelectionBackground": "#3399FF",
        "list.activeSelectionForeground": "#FFFFFF",
        "list.inactiveSelectionBackground": "#CCCEDB",
        "list.focusBackground": "#DCEBFC",
        "list.hoverBackground": "#F0F0F0",
        "list.highlightForeground": "#007acc",
        "inputOption.activeBorder": "#007ACC",
        "pickerGroup.border": "#CCCEDB"
    }

These values were taken directly from VSCode Light+ theme and defaults here and here.

If you find any other color missing, you can search on the files above for the same code.

[glambert]

That'll do it for now, thanks a lot! I will keep myself to subscribed to this if you find a way to make this an option 😉

[FabriceMk]

Thanks, I was also hoping for the same thing. I really like your theme but as @ls-guillaume-lambert I prefer to keep the workbench as default.

Thank you for the default values. This will do it for now. Maybe if it's not possible we could create an issue on the VSCode repo.

[akamud]

I think I'll release this theme with 2 options: "Atom One Light" and "VSCode One Light", the latter being editor theming without workbench theming.

What do you think?

[FabriceMk]

I don't know how the Search engine works in VSCode Marketplace but dropping the Atom keyword is maybe a mistake because people will have trouble to find it. Except if in the description of the main one you put a link to the special version without the customized workbench for people who wants it.

[akamud]

They will both be bundled in the same extension in the marketplace.

Extensions can come with multiple themes... so you would still install it as you do today, but it would come with 2 themes.

I'm not sure if I will do this yet. I'm just thinking of alternatives.

[glambert]

2 themes is fine imo, Atom One Light is also OK.

[FabriceMk]

@akamud Then it's fine I guess, just add this in the description of the extension to let people know.