akamud / vscode-theme-onelight

VSCode Theme based on Atom's One Light theme
MIT License
76 stars 55 forks source link

Information message text is white on white background #4

Open cxcorp opened 7 years ago

cxcorp commented 7 years ago

The text of the notification popup is invisible because the text is of the same colour as the background.

Sample code

This Hello World extension example can be used to open notification popups. https://code.visualstudio.com/docs/extensions/example-hello-world

Filename and Language selected

Doesn't apply

Atom Original theme Screenshot

Doesn't apply

VSCode theme Screenshot

screen shot 2017-06-07 at 10 46 00

Versions used

akamud commented 7 years ago

Thank your for reporting, this will be fixed in 2.0.2. I'll let you know when it is released.

akamud commented 7 years ago

I reverted the notification bar to a dark background for the moment.

image

VSCode does not allow me to change the colors for the buttons and badges in the notification bar alone, leading to bad coloring. I opened an issue on the official repo, until they add this, I'll have to keep the dark notification bar (like VSCode light theme).

If they add this I'll update this issue and release a better coloring.

I'll release the dark notification bar in 2.0.2 soon, I'll ping back when it is available.

akamud commented 7 years ago

This is now released in 2.0.2.

cxcorp commented 7 years ago

Awesome! Thanks!