Full workbench warning window missing support

akamud / vscode-theme-onelight

VSCode Theme based on Atom's One Light theme

MIT License

79 stars 54 forks source link

Full workbench warning window missing support #7

Closed ghost closed 7 years ago

ghost commented 7 years ago

Sample code

Not applicable

Filename and Language selected

Not applicable

Atom Original theme Screenshot

Not applicable

VSCode theme Screenshot

Versions used

VSCode version: 1.13.1
Theme version: 2.0.2

Extra information

As showed in the screenshot the color of the window is not correct.

akamud commented 7 years ago

Thank you for taking the time submitting this issue. It has come up before, reported in #4, since then I opened an issue on VSCode asking for better theming support on notification windows, which is already fixed, but not yet released (as of 1.13), I believe this will be in place for 1.14, but there is no way of knowing at the moment.

I'll fix this when it is available for customization and I'll report back here.

ghost commented 7 years ago

Thanks and sorry for the duplicate!

ghost commented 7 years ago

Hi @akamud it seems that it has been fixed!

akamud commented 7 years ago

Yes, I'll update over the next weekend. I didn't have the time to do that yet, sorry about that.