akanazawa / cmr

Project repo for Learning Category-Specific Mesh Reconstruction from Image Collections
MIT License
474 stars 84 forks source link

Undefined name 'convert2np' in ./benchmark/evaluate.py #2

Closed cclauss closed 6 years ago

cclauss commented 6 years ago

There is a missing import in ./benchmark/evaluate.py so that convert2np() is and undefined name.

convert2np() is defined at https://github.com/akanazawa/cmr/blob/master/utils/bird_vis.py#L177

flake8 testing of https://github.com/akanazawa/cmr on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./benchmark/evaluate.py:102:28: F821 undefined name 'convert2np'
        img = np.transpose(convert2np(batch['img'][0]), (1, 2, 0))
                           ^
1     F821 undefined name 'convert2np'
1
shubhtuls commented 6 years ago

Thanks for pointing this out! Updated the file to import it.