akanchi / mpegts

A simple implementation of mpegts(including muxer and demuxer)
MIT License
24 stars 17 forks source link

Made some changes and updated build system #6

Closed andersc closed 4 years ago

andersc commented 4 years ago
andersc commented 4 years ago

Added automatic build of the lib and executables.. The readme needs to be updated to match the badges on the master repository if merged.

andersc commented 4 years ago

Removed the _ prefixes as for C++ it's not recommended to be used ->

https://softwareengineering.stackexchange.com/questions/191828/might-starting-variables-members-with-an-underscore-puzzle-the-compiler

https://stackoverflow.com/questions/3136594/naming-convention-underscore-in-c-and-c-sharp-variables/20496955

andersc commented 4 years ago

Added prefixes following the rules -> // Prefixes used // m class member // p pointer (*) // r reference (&) // l local scope

And changed to camelCase

andersc commented 4 years ago

The 'Multi TS-Packet demux-bug fixed' https://github.com/akanchi/mpegts/pull/6/commits/ae8b73a4783c589afe78bba6ae37fc5b9da7ad86

Should be cherrypicked and verified.

akanchi commented 4 years ago

Removed the _ prefixes as for C++ it's not recommended to be used ->

https://softwareengineering.stackexchange.com/questions/191828/might-starting-variables-members-with-an-underscore-puzzle-the-compiler

https://stackoverflow.com/questions/3136594/naming-convention-underscore-in-c-and-c-sharp-variables/20496955

I prefer Google's code style https://google.github.io/styleguide/cppguide.html#Variable_Names

andersc commented 4 years ago

Fully understand.. I will close this pull-request and continue working on my fork.. Will let you know if I find any bugs... (BTW .. tnks for a great project! )

akanchi commented 4 years ago

Thanks, and I want to synchronize your changes to autobuild and CMakeLists.txt