search

akanimax / BMSG-GAN

[MSG-GAN] Any body can GAN! Highly stable and robust architecture. Requires little to no hyperparameter tuning. Pytorch Implementation
MIT License
629 stars 105 forks source link

Sagemaker config #7

Closed markstrefford closed 5 years ago

markstrefford commented 5 years ago

Review my changes, I made a couple of others as I was getting 'mod by 0' errors on a small training set. Also, I've not tested this without Sagemaker, it should work natively too. If we want me to back any changes out, let me know and I'll do that before resubmitting the PR.

akanimax commented 5 years ago

@markstrefford, Thanks a lot. Looks great! I'll go through your changes :+1: Best regards, @akanimax

akanimax commented 5 years ago

I have gone through the changes. They are all good. :+1:. Thanks. Could you please address the above two comments of mine? I'll be happy to merge the changes. Thanks again!

Best regards, @akanimax

markstrefford commented 5 years ago

Will do

markstrefford commented 5 years ago

Closing as requested, new pull request on its way.