akanix42 / meteor-css-modules

MIT License
92 stars 20 forks source link

Upgrading node-sass to version 4? #93

Closed neoromantic closed 7 years ago

neoromantic commented 7 years ago

Is there any particular reason that meteor-css-modules requires node-sass 3 instead of current version (which is 4)?

There are several unrelated reasons of which I have to use node-sass4. So i get this warning:

WARNING: version mismatch for node-sass; installed version is 4.5.1, but version 3.x is required by nathantreid:css-modules)

Things works good with 4.5.1. Is there a reason to require v3?

akanix42 commented 7 years ago

No, it seems to work fine - I just need to release a patch that adds v4 to the supported versions.

neoromantic commented 7 years ago

That’s great! Waiting for that patch :)

Sergey.

On Mar 23, 2017, at 10:54 PM, Nathan Reid notifications@github.com wrote:

No, it seems to work fine - I just need to release a patch that adds v4 to the supported versions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .

akanix42 commented 7 years ago

This has been fixed in v2.5.2.