search

akankshag12 / homework-landingpage

0 stars 0 forks source link

Feedback on assignment #2 #1

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #2 Project: Styling with CSS

Description

A hot, new NY Tech Startup, Relaxr, has approached you to help them develop a new landing page for their company. They've handed you the design file for the site, along with the copy and assets. You need to take these files and turn it into a landing page.

Student: Akanksha Garg

Project URL: https://github.com/akankshag12/homework-landingpage
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use HTML5 structural elements (nav, header, footer) x
Use a CSS Reset file in addition to your style.css file to style the page x
Use IDs and Classes to to select and style elements on the page x
Style your text with the Google Fonts provided by your style guide x
Follow naming conventions, maintain consistency across .html and .css files and use best practices for naming IDs and Classes x
Indent nested elements to increase your code's readability x
TOTAL: 11/12
barryross commented 7 years ago

Hey AK,

Overall, you have done a great job on this assignment! Great work meeting nearly all of the design specs. There were a couple font-sizes and weights I noticed that differed from the spec, but overall things are looking great.

I left off a mark for IDs and Classes just because I didn't see any #ids in your code. I think the "benefits" section may be a good place for this.

Great work thinking to use padding to help achieve a consistent vertical alignment of your content. Another approach would be to use a shared ".container" class (example in the solution code) which would help provide a consistent width for your content. Please see inline comments for more feedback, and keep up the great work!