search

akanshmurthy / railsbridge-testfest

The skeleton app.
MIT License
4 stars 2 forks source link

Stop tracking config/secrets.yml ? #13

Closed siruguri closed 7 years ago

siruguri commented 7 years ago

I'm writing tests for bitly, and need to test the test with a Bitly client. I want to leave in some pieces of the code I'm writing, as a best practice example - specifically how to initialize the client with a password.

I usually check in config/secrets.yml, but use the dotenv gem - but that might be too many steps for a beginner coder. Instead, I want to stop tracking config/secrets and add it to .gitignore I can also create a config/secrets.yml.sample that does get checked in.

Is this strategy ok by you guys?

siruguri commented 7 years ago

@schaui6 @akanshmurthy

schaui6 commented 7 years ago

@siruguri sounds good to me

akanshmurthy commented 7 years ago

Sounds good. I'm even leaving out the client altogether so that they can go to the API documentation and figure it out but it might be good to have one with a client so that they can understand a bit better.

siruguri commented 7 years ago

Thanks.

Typed on a phone

On Nov 2, 2016 1:49 PM, "Akansh Murthy" notifications@github.com wrote:

Sounds good.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/akanshmurthy/railsbridge-hackathon/issues/13#issuecomment-257994508, or mute the thread https://github.com/notifications/unsubscribe-auth/AACezbC-WCtPxVlrnnN9oFMPAf5vIBshks5q6PdRgaJpZM4Knkak .