Bitly gem vs bare metal get

[siruguri]

In #5, @philnash points out wisely that the code base now:

• has an unnecessary dependency on the Bitly gem,
• does not adequately deal with the resulting network exceptions that Net::HTTP could generate.

I think a short-term solution is to remove the dependency, and comment in the code on the above disadvantage of this choice, so that students understand the pros and cons.

Long-term, we could use the gem and also rescue from its own exceptions/properly check for errors. That would also be something we should illustrate with all API calls.

Probably best to handle after the 11/4 hackathon.

[schaui6]

@philnash thanks :) @siruguri I'm okay with the short term solution

[siruguri]

PR coming up

On Thu, Nov 3, 2016 at 7:09 PM, Sanderfer notifications@github.com wrote:

@philnash https://github.com/philnash thanks :) @siruguri https://github.com/siruguri I'm okay with the short term solution

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/akanshmurthy/railsbridge-hackathon/issues/18#issuecomment-258327551, or mute the thread https://github.com/notifications/unsubscribe-auth/AACezRQ2il1kO2Gx-XjCDF1Gu18M2gyKks5q6pPsgaJpZM4KpDvG .

[schaui6]

ok ill keep an eye out

[schaui6]

@siruguri ok PR merged, I'll keep this issue open so we can work on the long-term solution in the future