search

akaps / hanabi_ai

AI competition of the card game Hanabi, where the best AI is measured as the most cooperative and contributes to the highest scoring games
MIT License
1 stars 2 forks source link

Add Linter with no functionality #118

Closed akaps closed 5 years ago

akaps commented 5 years ago

Adds pylint to the project and ensures it fully passes. It does this by running no rules. Adds pylint to script phase of travis to enforce style on future PRs Added issues for each disabled rule to enable them in the future.

All Submissions:

  1. [ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change? There is, but this is the clean way to resolve that behemoth that is currently broken
  2. [x] Have you written new tests for new features/fixes for bugs?

New Feature Submissions:

  1. [x] Does your submission pass tests?
  2. [x] Have you linted your code locally prior to submission?

Changes to Core Features:

  1. [x] Have you written new tests?
  2. [x] Have you linted your code locally prior to submission?
  3. [x] Have you added an explanation to your changes and why you'd like them included?
  4. [x] Does your submission pass tests locally?
akaps commented 5 years ago

Throwing this out. Should be able to make progress with #123

akaps commented 5 years ago

Resolved with #125