search

akapur / pyiqfeed

Python LIbrary for reading DTN's IQFeed
GNU General Public License v2.0
172 stars 109 forks source link

Wrote new classes NewsConn, DerivConn, DerivativeInfo, new examples.py and more #5

Closed erickmiller closed 8 years ago

erickmiller commented 8 years ago

Check revision history for full story, these changes represent several days of coding and testing.

I was careful to add copius and generous comments when appropriate to explain any changes that were made.

Here are a few highlights: -New classes: NewsConn, DerivConn and DerivativeInfo -Added new listener classes VerboseDerivListener and SilentDerivListener to support new class -Linux usability dramatically increased by robustification of the posix version of FeedService.launch() works great with near zero latency to connect and works great streaming across multiple Python processes all calling pyiqfeed at the same time -New example code added to example.py to test the new classes and put everything through it's paces -Printing slightly more verbose output for examples so it's easier to see what's going on -Tweaked the relative import in conn.py so that documentation can be autogenerated using pydoc3.5

Good stuff. Do a code review and let me know what you think, have spent almost one full day testing this new code and all seems to be stable enough to send you a pull request.

With this update pyiqfeed should have near 100% code coverage for the DTN TCP/IP requests API! Word up.

akapur commented 8 years ago

Thanks for the fantastic work. Will be doing some extensive testing today.

erickmiller commented 8 years ago

Hey Ashwin, Thanks for the kind words. Noticed you reverted the changes - can you send me the issues so I can fix them please? I don't see the info in the comments of the revert or in this thread (are the comments somewhere else?) Thanks