Closed GoogleCodeExporter closed 9 years ago
Hi Adam,
I have found out that the issue has something to do with the
maven-bundle-plugin declaration.
When I replace <packaging>bundle</packaging> with <packaging>jar</packaging> in
psul-services/pom.xml , the addjars plugin works.
I will investigate the issue further and try to resolve it.
Meanwhile I suggest introducing one more module (say, psul-libs) to workaround
the issue.
The module should be of type 'pom' and contain the addjars-maven-plugin
declaration.
The psul-services module should depend on psul-libs.
Please let me know whether this solution works for you.
Thank you.
Original comment by v.kary...@gmail.com
on 17 Jun 2012 at 9:57
Original comment by v.kary...@gmail.com
on 17 Jun 2012 at 10:03
I took the time this evening to clone your code to my local machine...
I changed the line (in file AddJarsMojo.java)....
File pomFile = new File(workdir, "pom-modified.xml");
to
File pomFile = new File(workdir, "pom.xml");
Built and deployed to local repository... it works now for me for both jar and
bundle package type. I need to use bundle though, I tested with just jar and
it does not meet my OSGI requirements. If there was not a reason behind having
it named pom-modified.xml and not pom.xml maybe you can add this change to your
tool. This plug in could be very useful for many other OSGI developers out
there, so if the change doesn't break anything else...
p.s. thanks again, and it was cool to see how these maven plugins are built :)
It was as easy as 123 to check out and build with netbeans, good times...
-Adam
Original comment by adamyo...@gmail.com
on 19 Jun 2012 at 2:31
Thank you for providing the patch, Adam.
I have released it in a new version of plugin (1.0.4). The new version should
become available in maven central repository within the next few hours.
Agree, such a plugin should have been implemented years ago.
It's strange that the orthodox maven developers have been ignoring such an
obvious need.
Original comment by v.kary...@gmail.com
on 19 Jun 2012 at 8:07
Original issue reported on code.google.com by
adamyo...@gmail.com
on 15 Jun 2012 at 6:30Attachments: