akash-network / awesome-akash

Awesome List of Akash Deployment Examples
Apache License 2.0
308 stars 223 forks source link

FLock template #522

Closed fengzz-coding closed 4 months ago

fengzz-coding commented 4 months ago

FLock template add.

anilmurty commented 4 months ago

Thanks for this @fengzz-coding - a couple comments (as discussed in slack):

  1. Will be great if you could add a little more context (at least what and why. Ideally a video if possible) in the readme. This will help boost usage of it. Here is a good recent example of one https://github.com/akash-network/awesome-akash/blob/master/vllm/README.md
  2. May want to consider not filtering GPUs - so user gets more bids
anilmurty commented 4 months ago

@Dimokus88 - could you please review/ test/ merge when you have the chance?

Dimokus88 commented 4 months ago

The main check is in progress. There are currently some issues that need to be addressed before inclusion in the awesome-akash repository:

  1. Add a Dockerfile of the image public.ecr.aws/e7z6j8c3/flock:llm-loss-validator-gpu-latest . Also, if there is an executable script inside the image, they also need to be added as a file.

  2. You need to add information about your template to the root README.md of the awesome-akash repository

fengzz-coding commented 4 months ago

Thanks for this @fengzz-coding - a couple comments (as discussed in slack):

  1. Will be great if you could add a little more context (at least what and why. Ideally a video if possible) in the readme. This will help boost usage of it. Here is a good recent example of one https://github.com/akash-network/awesome-akash/blob/master/vllm/README.md
  2. May want to consider not filtering GPUs - so user gets more bids
  1. Got it. My team and I will see if we can provide a video tutorial.
  2. We will run a large language model and need a GPU with 24GB of VRAM, Only these graphics cards meet our requirements.
fengzz-coding commented 4 months ago

The main check is in progress. There are currently some issues that need to be addressed before inclusion in the awesome-akash repository:

  1. Add a Dockerfile of the image public.ecr.aws/e7z6j8c3/flock:llm-loss-validator-gpu-latest . Also, if there is an executable script inside the image, they also need to be added as a file.
  2. You need to add information about your template to the root README.md of the awesome-akash repository
  1. For the Docker build, you can refer to this https://github.com/FLock-io/llm-loss-validator/blob/main/Dockerfile-gpu. What else needs to be provided for this?
  2. Got it.
Dimokus88 commented 4 months ago
  1. For the Docker build, you can refer to this https://github.com/FLock-io/llm-loss-validator/blob/main/Dockerfile-gpu. What else needs to be provided for this?

It is necessary that users know what kind of image will be deployed (and, if desired, could assemble it themselves). This is why there is a need to publish a Dockerfile for custom images. Or add a link to the Dockerfile in your README.md

Dimokus88 commented 4 months ago

SDL looks working. But it is necessary to clarify/correct the recommendations above. Adding information to README.md and publishing a Dockerfile (or a link to it). Users need to see what they are deploying.

fengzz-coding commented 4 months ago

SDL looks working. But it is necessary to clarify/correct the recommendations above. Adding information to README.md and publishing a Dockerfile (or a link to it). Users need to see what they are deploying.

Done. Pls have a look.

Dimokus88 commented 4 months ago

Thx @fengzz-coding ! Looks ready to merge @anilmurty !

anilmurty commented 4 months ago

Thanks @Dimokus88