akash-network / support

Akash Support and Issue Tracking
Apache License 2.0
5 stars 4 forks source link

Make provider attributes available in bids #124

Closed baktun14 closed 10 months ago

baktun14 commented 1 year ago

The scope of this is larger than just GPU attributes but GPU model is the biggest painpoint at this time.

When deploying for a GPU, the bid engine doesn't return the GPU model or vendor. This is crucial for users to know which provider to choose for which model, especially when deploying with a wildcard in the SDL.

Here's an example of a bid:

{
    "bid": {
        "bid_id": {
            "owner": "akash1...tkvk",
            "dseq": "12793097",
            "gseq": 1,
            "oseq": 1,
            "provider": "akash19p4t9d069nashxre9jg6j60cqlqkvtht6egpc9"
        },
        "state": "open",
        "price": {
            "denom": "uakt",
            "amount": "368.320765000000000000"
        },
        "created_at": "12793100"
    },
    "escrow_account": {
        "id": {
            "scope": "bid",
            "xid": "akash...tkvk/12793097/1/1/akash1...pc9"
        },
        "owner": "akash1...pc9",
        "state": "open",
        "balance": {
            "denom": "uakt",
            "amount": "5000000.000000000000000000"
        },
        "transferred": {
            "denom": "uakt",
            "amount": "0.000000000000000000"
        },
        "settled_at": "12793100",
        "depositor": "akash1...pc9",
        "funds": {
            "denom": "uakt",
            "amount": "0.000000000000000000"
        }
    }
}

Also, if the protobuf types are to change for the bids, I think it would be a great idea to also add the model/vendor chosen on the deployment or lease. Currently on the deployment, we can see the model/vendor requested, but not the one leased.

baktun14 commented 1 year ago

Also, I think it would be a great idea to have something generic to handle other specs/attributes than GPUs, like the type of CPU offered or memory or disk etc etc. To not have to change the protobuf type later on. Something like an attribute array.

anilmurty commented 11 months ago

Oct 17 sync: This will need a network upgrade

brewsterdrinkwater commented 11 months ago

Oct 24 sync:

brewsterdrinkwater commented 11 months ago

oct 31st:

anilmurty commented 11 months ago

Nov 7: