search

akash-network / support

Akash Support and Issue Tracking
5 stars 4 forks source link

too many existing bids (20) #28

Closed andy108369 closed 1 year ago

andy108369 commented 2 years ago

akash v0.16.4

continuing https://github.com/ovrclk/akash/issues/1660 here

  1. more than 20 open bids across all providers:
$ akash query market bid list --state open | grep dseq | wc -l
23
  1. 0 open bids for the provider (AMS1):
$ akash query market bid list --state open --provider akash14c4ng96vdle6tae8r4hc2w4ujwrsh3x9tuudk0 | grep dseq | wc -l
0
  1. AMS1 provider has 0 pending order:
$ curl -s -k https://provider.provider-0.prod.ams1.akash.pub:8443/status | jq -r '[.cluster.leases, (.cluster.inventory.active|length), .bidengine.orders, .manifest.deployments] | @csv'
39,39,0,0
  1. seeing only my order request for AMS1 provider:
$ akash query market bid list --state open --provider akash14c4ng96vdle6tae8r4hc2w4ujwrsh3x9tuudk0 | grep dseq | wc -l
1
  1. provider gets too many existing bids (20): unknown provider
$ akash query tx 4E7D3B9EC2C821F81AAE473D7AAD68643D38D2772904700914D2C5D9766F10C7 -o json | jq -r '.raw_log'
failed to execute message; message index: 0: too many existing bids (20): unknown provider

Probably worth noting that this, somehow, works better when not using a state-sync RPC node. I.e. I have not hit this issue each time I switched from state-sync RPC node back to the full (archive) RPC node. Or maybe I just hit the right point in time.

I'll leave AMS1 with state-sync RPC node for now.

https://www.mintscan.io/akash/txs/4E7D3B9EC2C821F81AAE473D7AAD68643D38D2772904700914D2C5D9766F10C7 https://www.mintscan.io/akash/txs/6A81D3845A71B1F12FB32EF4290EDB6A04943D1EE07E1A7285E6C28994A76245

andy108369 commented 2 years ago

It hits me, I never seem to remember seeing more offers than for 20 / 21 providers:

$ akash_accept 
    rate    monthly usd dseq/gseq/oseq  provider                    host
0>  27.00   10.96   $2.82   6741753/1/1 akash1qk9dg3kr3jx6q5l2uf7g7mm8st2mr8ylfakepy    provider.xeon.computer:8443 
1>  40.00   16.25   $4.19   6741753/1/1 akash1qhjtxmacslmefm3v4sn5ggq6ed9jn83cy2rjd0    provider.akash.rocks:8443   
2>  16.51   6.70    $1.73   6741753/1/1 akash1zwzf72lcmaywvwnszzqfaygw6ax3vn3h3kheap    provider.starshipaxiom.com:8443 
3>  22.00   8.93    $2.30   6741753/1/1 akash1zlsep362zz46qlwzttm06t8lv9qtg8gtaya97u    provider.america.computer:8443  
4>  63.43   25.77   $6.64   6741753/1/1 akash1ra00m26cdy42j0988q2szpyqrrg7xfqrktqult    provider.thanosnode.com:8443    
5>  14.00   5.68    $1.46   6741753/1/1 akash19yhu3jgw8h0320av98h8n5qczje3pj3u9u2amp    provider.bdl.computer:8443  
6>  18.00   7.31    $1.88   6741753/1/1 akash1xcclnvcl7nup95lp8tp9jzf54q8wk6t0uwjkzj    provider.sfo.computer:8443  
7>  22.00   8.93    $2.30   6741753/1/1 akash18ga02jzaq8cw52anyhzkwta5wygufgu6zsz6xc    provider.europlots.com:8443 
8>  120.00  48.75   $12.56  6741753/1/1 akash1g8m36ge6yekgkfktl08x8vrp0nq9v0l73jzy32    provider.xch.computer:8443  
9>  24.14   9.80    $2.52   6741753/1/1 akash1fm4phdkvm659emptnpuxfk7g00fpyapy3h9948    aka.elotana.com:8443    
10> 53.00   21.53   $5.54   6741753/1/1 akash1vky0uh4wayh9npd74uqesglpaxwymynnspf6a4    provider.provider-2.prod.ewr1.akash.pub:8443    
11> 101.92  41.40   $10.66  6741753/1/1 akash1dy6fxzkg7n6402x9n04z9tc3hwl5r4j8vhjqcw    akash-01.crono.co:8443  
12> 45.00   18.28   $4.71   6741753/1/1 akash1wxr49evm8hddnx9ujsdtd86gk46s7ejnccqfmy    provider.bigtractorplotting.com:8443    
13> 19.63   7.97    $2.05   6741753/1/1 akash1wjd35e4ymmpfn2gnqju88qlcjtk5vlqge0yfca    provider.akash.bitcat365.com:8443   
14> 44.00   17.87   $4.60   6741753/1/1 akash10fl5f6ukr8kc03mtmf8vckm6kqqwqpc04eruqa    provider.akash.world:8443   
15> 19.63   7.97    $2.05   6741753/1/1 akash13pc20tekhj6fw6sjtjm79hgjelr0ljds3cektq    akash-provider.hashquark.io:8443    
16> 34.00   13.81   $3.56   6741753/1/1 akash1nxq8gmsw2vlz3m68qvyvcf3kh6q269ajvqw6y0    provider.akash.pro:8443 
17> 22.20   9.02    $2.32   6741753/1/1 akash15ksejj7g4su7ljufsg0a8eglvkje94z8qsh68a    palmito.duckdns.org:8443    
18> 19.63   7.97    $2.05   6741753/1/1 akash1k3xckl6nvu6pwdm3ysf8vz0hsph50nan3gh3cw    praetor.anaarbexpress.com:8443  
19> 53.00   21.53   $5.54   6741753/1/1 akash1m7tex89ddnwp3cm63ehfzfe2kj2uxmsugtx2qc    provider.provider-0.prod.sjc1.akash.pub:8443    
20> 71.15   28.90   $7.44   6741753/1/1 akash1uz6fslqf28fdhjtqa503sy7rp37vpw0xfnhgk8    provider.praetorapp.com:8443

my account akash1h24fljt7p0nh82cq0za0uhsct3sfwsfu9w3c9h:

akash$ akash query market bid list --state open --owner akash1h24fljt7p0nh82cq0za0uhsct3sfwsfu9w3c9h -o json | jq -r '.bids[].bid.bid_id.provider'
akash1q7spv2cw06yszgfp4f9ed59lkka6ytn8g4tkjf
akash1zwzf72lcmaywvwnszzqfaygw6ax3vn3h3kheap
akash1zlsep362zz46qlwzttm06t8lv9qtg8gtaya97u
akash1ra00m26cdy42j0988q2szpyqrrg7xfqrktqult
akash1yh6y4hdqql88e8g7la30zlunntan2n7gxae7ma
akash19yhu3jgw8h0320av98h8n5qczje3pj3u9u2amp
akash1xcclnvcl7nup95lp8tp9jzf54q8wk6t0uwjkzj
akash18ga02jzaq8cw52anyhzkwta5wygufgu6zsz6xc
akash1fm4phdkvm659emptnpuxfk7g00fpyapy3h9948
akash1vky0uh4wayh9npd74uqesglpaxwymynnspf6a4
akash1wxr49evm8hddnx9ujsdtd86gk46s7ejnccqfmy
akash1wjd35e4ymmpfn2gnqju88qlcjtk5vlqge0yfca
akash10fl5f6ukr8kc03mtmf8vckm6kqqwqpc04eruqa
akash13pc20tekhj6fw6sjtjm79hgjelr0ljds3cektq
akash1nxq8gmsw2vlz3m68qvyvcf3kh6q269ajvqw6y0
akash15ksejj7g4su7ljufsg0a8eglvkje94z8qsh68a
akash14vngw9q5txt5guttgsw27yrs048sx8s7yc2e74
akash1k3xckl6nvu6pwdm3ysf8vz0hsph50nan3gh3cw
akash1m7tex89ddnwp3cm63ehfzfe2kj2uxmsugtx2qc
akash1uz6fslqf28fdhjtqa503sy7rp37vpw0xfnhgk8
akash178cag5lyfrh7t3uq3cyfnqqgdtaaxemgejnc8d

$ akash query market bid list --state open --owner akash1h24fljt7p0nh82cq0za0uhsct3sfwsfu9w3c9h -o json | jq -r '.bids[].bid.bid_id.provider' | wc -l
21
andy108369 commented 2 years ago

We should probably increase OrderMaxBids from 20 to 40.

$ akash query params subspace market OrderMaxBids -o json | jq
{
  "subspace": "market",
  "key": "OrderMaxBids",
  "value": "20"
}

Related code paths:

andy108369 commented 2 years ago

Also, worth noting what @tidrolpolelsef said, which means that increasing the amount of OrderMaxBids could lead to increased gas:

Also going forward, I think that when closing a deployment that has a large number of active bids, gas should be partially deducted from all the bid deposits. The provider would normally pay the gas to close that bid anyways. It just happens when a deployment is closed instead. Sometimes to close deployments on mainnet I am having to set gas to something like 1.5 million.

andy108369 commented 2 years ago

Meanwhile, have just checked, when closing a deployment after bids timed out, that cost me 157,352 gas And, when closing a deployment right after I've got the bids, that cost me 1,232,226 gas (gas wanted 1,832,341) That is with no special placement attributes nor signedBy, 21 providers bid in total.

Got the same numbers when have also closed it after 1 minute of sleeping.

When with signedBy akash1365yvmc4s7awdyj3n2sav7xfx76adc6dnmlx63 - 15 providers - 958,745 gas used (1,065,271 gas wanted).

1,232,226 gas = 0.045809 AKT fee. Not too large to be too concerned, I think. At its current price at least.

But, yeah, we need to take this into account when increasing OrderMaxBids

tidrolpolelsef commented 2 years ago

An easy workaround is to just wait the default 5 minutes that providers have for them to close their bids. I don't think many people change this. If there is no lease after 5 minutes, the provider is going to close its bid preemptively.

andy108369 commented 1 year ago

Clients should use the attributes to limit their deployment requests to the providers they want to deploy at.

andy108369 commented 1 year ago

Reopening since it's time we lift this value up to 50.

andy108369 commented 1 year ago

@troian please have a look and let me know if it is safe to submit this proposal now or you want to test it in the testnet first?

troian commented 1 year ago

@andy108369 lets format the description and put it in the proposals section

andy108369 commented 1 year ago

@andy108369 lets format the description and put it in the proposals section

=> https://github.com/orgs/akash-network/discussions/149

andy108369 commented 1 year ago

proposal broadcasted => https://www.mintscan.io/akash/proposals/197

announced in the #governance discord channel https://discord.com/channels/747885925232672829/784452434604982283/1093247268548788284

andy108369 commented 1 year ago

Proposal #197 passed! The OrderMaxBids parameter has been updated from 20 to 50.

$ akash query gov proposal 197 -o json | jq -r '.status, .voting_end_time'
PROPOSAL_STATUS_PASSED
2023-04-12T19:03:20.032599861Z

$ akash query block 10594876 | jq -r '.block.header.time'
2023-04-12T19:03:14.999700372Z

$ akash --height 10594876 query params subspace market OrderMaxBids -o json | jq
{
  "subspace": "market",
  "key": "OrderMaxBids",
  "value": "20"
}

$ akash query block 10594877 | jq -r '.block.header.time'
2023-04-12T19:03:20.874033546Z

$ akash --height 10594877 query params subspace market OrderMaxBids -o json | jq
{
  "subspace": "market",
  "key": "OrderMaxBids",
  "value": "50"
}