akash-network / support

Akash Support and Issue Tracking
5 stars 4 forks source link

"akash query market lease" is always showing a 0 escrow_account.balance.amount #43

Open arno01 opened 2 years ago

arno01 commented 2 years ago

akash v0.14.1

akash query market lease <get/list> is always showing a 0 escrow_payment.balance.amount:

$ akash query market lease get --dseq 4951348 --provider akash14c4ng96vdle6tae8r4hc2w4ujwrsh3x9tuudk0 --owner akash1h24fljt7p0nh82cq0za0uhsct3sfwsfu9w3c9h -o text
escrow_payment:
  account_id:
    scope: deployment
    xid: akash1h24fljt7p0nh82cq0za0uhsct3sfwsfu9w3c9h/4951348
  balance:
    amount: "0"                                   <<<<<<<<<<<<<<<<<<<<<<<<<<<<< this one is always 0
    denom: uakt
  owner: akash14c4ng96vdle6tae8r4hc2w4ujwrsh3x9tuudk0
  payment_id: 1/1/akash14c4ng96vdle6tae8r4hc2w4ujwrsh3x9tuudk0
  rate:
    amount: "5"
    denom: uakt
  state: open
  withdrawn:
    amount: "728460"
    denom: uakt
...
$ akash query deployment get --dseq 4951348 --owner akash1h24fljt7p0nh82cq0za0uhsct3sfwsfu9w3c9h -o text
deployment:
  created_at: "4951349"
  deployment_id:
    dseq: "4951348"
    owner: akash1h24fljt7p0nh82cq0za0uhsct3sfwsfu9w3c9h
  state: active
  version: SblWLPSAprhF20pDUIb8etw7TqubSq+RFpSZZGJmd28=
escrow_account:
  balance:
    amount: "4271540"                                   <<<<<<<<<<<<<<<<<<<<<<<<<<<<< looks good (as expected); and is also reflecting the correct value after `akash tx deployment deposit --dseq <###>`
    denom: uakt
  id:
    scope: deployment
    xid: akash1h24fljt7p0nh82cq0za0uhsct3sfwsfu9w3c9h/4951348
  owner: akash1h24fljt7p0nh82cq0za0uhsct3sfwsfu9w3c9h
  settled_at: "5097052"
  state: open
  transferred:
    amount: "728460"
    denom: uakt
...
hydrogen18 commented 2 years ago

I don't look at this very often but on akash query market lease get you'll notice it says escrow_payment not escrow_account. The actual amount that has been moved into a provider's wallet is under withdrawn. I think that displaying balance here may be a mistake entirely. It doesn't contain information as we don't hold funds in a provider's escrow payment fund. Instead when the lease withdraw TX is processed it winds up directly in their wallet.

arno01 commented 2 years ago

Is escrow_payment used at all? I think I've never seen the escrow_payment to have any other than 0 value there.

hydrogen18 commented 2 years ago

No we can probably remove it.

hydrogen18 commented 2 years ago

@boz any objection to me removing this info?