search

akash-network / support

Akash Support and Issue Tracking
Apache License 2.0
5 stars 4 forks source link

Validation of manifests is wrong around hostname requirements #62

Open hydrogen18 opened 3 years ago

hydrogen18 commented 3 years ago

I got this check wrong https://github.com/ovrclk/akash/blob/master/provider/service.go#L83

It should be 

HTTPServicesRequireAtLeastOneHost: !cfg.DeploymentIngressStaticHosts,

Also while looking into this I realized we have this code that makes sense:

https://github.com/ovrclk/akash/blob/master/provider/cluster/kube/settings.go#L40

But we don't call it anywhere.

hydrogen18 commented 3 years ago

First part has been fixed, the other validation code needs to be called somewhere