search

akashgoswami / ipm

IOTA node peer manager. Useful for monitoring IOTA peers
MIT License
72 stars 24 forks source link

Random Transactions show the same amount as New #2

Closed alon-e closed 7 years ago

alon-e commented 7 years ago

The dashboard shows the same numbers for New & Random transactions: image

however, reading the getNeighbors command show s different values:

      "address": "first",
      "numberOfAllTransactions": 205235,
      "numberOfRandomTransactionRequests": 81818,
      "numberOfNewTransactions": 158093,
      "numberOfInvalidTransactions": 0,
      "numberOfSentTransactions": 298727,
      "connectionType": "tcp"
    },
    {
      "address": "second",
      "numberOfAllTransactions": 231787,
      "numberOfRandomTransactionRequests": 87379,
      "numberOfNewTransactions": 13618,
      "numberOfInvalidTransactions": 0,
      "numberOfSentTransactions": 305841,
      "connectionType": "tcp"
    },
nicoschtein commented 7 years ago

This is indeed happening, check this line: https://github.com/akashgoswami/ipm/blob/master/public/component/peer.js#L24 Also Sent and shows Invalid: https://github.com/akashgoswami/ipm/blob/master/public/component/peer.js#L27

                <div class="list-group-item" href="#"> <span class="badge bg-success">{{state.numberOfAllTransactions}}</span>Total Transactions  </div> 
                <div class="list-group-item" href="#"> <span class="badge bg-success">{{state.numberOfNewTransactions}}</span> Random Transactions  </div> 
                <div class="list-group-item" href="#"> <span class="badge bg-success">{{state.numberOfNewTransactions}}</span> New Transactions  </div> 
                <div class="list-group-item" href="#"> <span class="badge bg-success">{{state.numberOfInvalidTransactions}}</span>Invalid Transactions  </div> 
                <div class="list-group-item" href="#"> <span class="badge bg-success">{{state.numberOfInvalidTransactions}}</span>Sent Transactions </div> 
                </div>
akashgoswami commented 7 years ago

Copy paste error. Thanks & Fixed it.

nicoschtein commented 7 years ago

oh, @akashgoswami beat me to it! nice work !