search

akashgoswami / ipm

IOTA node peer manager. Useful for monitoring IOTA peers
MIT License
72 stars 24 forks source link

Update counter and graph labels #34

Closed crwatkins closed 6 years ago

crwatkins commented 6 years ago

I found the existing counter labels to be a bit confusing at best (the API documentation on them is even worse), so I very quickly reviewed the iri code and hopefully came up with some better (and more accurate) labels. I reordered them (in a compromise of importance and relation to each other). I also changed a single graph label to match, but I did not reorder the graph labels because I did not want to change the actual graph display at this point. This is what changed:

All Transactions -> Received Transactions
Random Transactions -> Received Random Transaction Requests
New Transactions ->  Received New Transactions
Invalid Transactions -> Received Invalid Transactions
Sent Transactions ->  Sent Transactions

Here is a preview:

image

opel22 commented 6 years ago

Hi Craig, thanks a lot for your update. However, I still don't understand the meaning of those different kind of transactions, what they represent and how they should look like. "Received Transaction" - higher equals better? When a neighbor has a small amount, shall I look for another neighbor? If so: why? "Received Random Transaction Requests" - what is a "Random Transaction"? Where they come from? Should the number be high or low? Why? "Received New Transactions" - since last start of my node? Or since the last start of the neighbors node? How should the number look like? Is there a minimum per hour? If yes: why? "Received Invalid Transactions" - ok, that are invalid transactions, but what exactly do they represent? When is a transaction invalid? Why can such transactions occur? What is to do or what can be done if neighbors have invalid transactions? "Sent Transactions" - I guess that are transactions I sent out, but when I did no transaction, why then is the number so high? Are that transactions I received from neighbor A and then sent to neighbor B, because he did not have it at this time? And overall: is there some "relation" between those numbers, for example: "Invalid Transactions" should not exceed 10% of "Received Transactions" or similar? I hope you can guide me to the relevant information, thx! regards. oliver

akashgoswami commented 6 years ago

Thanks Craig for the contribution. Much appreciated!

crwatkins commented 6 years ago

@opel22, you have some great questions, but as @akashgoswami implied in your original issue, this may not be the best place to ask your questions. In particular this thread is a pull request for making label changes. You are asking questions that pertain to the iri project, and you are much more likely to get better answers there or in one of their forums.