Closed jcooper-korg closed 4 years ago
The idea behind it is to fit everything on a narrow screen, hence the C instead of Cancel. What should we use instead of Disarm as it's a bit too long?
Seems like there's plenty of room to just make the buttons wider and use the words "Clear" and "Disarm":
Ok, I'll give it a try.
Actually, you can play with it for yourself locally and tell us what works best. Just make the following changes to resources/panel.html:
line 192: replace C with Clear, i.e
<mwc-button class='clear action-button' on-click='callclearcode' raised>Clear</mwc-button>
and line 195: you need a button here as well, not an icon
<mwc-button class='action-button disarm' on-click='callAlarmService' data-call='disarm' raised>Disarm</mwc-button>
implemented in commit 6010c336.
I also modified the sm (tablet width > 1024) view to have the same button groupings with 0 at bottom center:
I'm still experimenting with increasing the button sizes in the sm tablet view.
not sure if these changes are desirable for everyone. i can send a pull request if you think so. would probably be nicer if it was made optional in the theme, but i wasn't sure the best way to approach that
let me think about it as there's no rush.. ;)
I think the disarm button is far and away more logic for mot people. I have the same problem with people not knowing how to use it - though less critical because mostly arm/disarm through presence automations.
The fingerprint icon in the portrait view (as seen on an iPhone) is not very attractive, and potentially confusing (implies you can use the fingerprint sensor on the iPhone). I'd prefer this just say "disarm".
Can we make it optional in the theme?