akasma74 / Hass-Custom-Alarm

It is a fork of "Yet another take on a home assistant custom alarm" that will exist until its author is back to our Earth
80 stars 31 forks source link

Show open sensor list on arming page #43

Open jcooper-korg opened 4 years ago

jcooper-korg commented 4 years ago

In the previous version of this alarm panel, the arming page showed a list of sensors below the "home" and "away" buttons. This was very helpful, to immediately see what windows/doors are open, when trying to alarm the panel, without having to change to a different page. In the current implementation, there is plenty of space on the main screen, with just two buttons "home" and "away". And when you press one of those buttons, then it shows a second page with "open sensors found".
So maybe this can made optional in the theme?

akasma74 commented 4 years ago

The thing is it can be a bit misleading as when disarmed, what sensors should we monitor - listed in immediate/delayed groups of armed_away, armed_home or armed_night or combination of them?

akasma74 commented 4 years ago

Any thoughts @jcooper-korg ?

akasma74 commented 4 years ago

@jcooper-korg, to be able to make this enhancement I need an answer to my question above.

jcooper-korg commented 4 years ago

The pre-newUI system just listed the open sensors under the arming buttons with a heading like "5 Open Sensors", and then the list of those open sensors. I think that's acceptable. Yes, some sensors may apply to the AWAY while some apply to HOME, but that's fine. It cannot know which button you're about to press, so it just lists all open sensors (e.g. I would know to ignore open motion sensors if I'm about to hit the HOME arming button).

I noticed that the newUI system changes the color of the sensors icon to yellow if there are any open sensors, and if you click on that icon, it shows all the open sensors, and a second list with "all sensors". So, i think it's as simple as showing that same list of open sensors on the main arming page. (This could be optional, if we add a new "show open sensors on arming page" option in the panel config/theme.)