search

akasma74 / Hass-Custom-Alarm

It is a fork of "Yet another take on a home assistant custom alarm" that will exist until its author is back to our Earth
80 stars 31 forks source link

MQTT Functionality Broken in 0.105 #80

Closed e2m32 closed 4 years ago

e2m32 commented 4 years ago

Your components (from Alarm/Settings/About):

Platform & Browser:

Describe the bug MQTT ARM_HOME, ARM_AWAY, DISARM broken

To Reproduce Steps to reproduce the behavior:

Expected behavior Alarm arms/disarms

Screenshots If applicable, add screenshots to help explain your problem.

Additional context I tested this with logger prints and the alarm receives the MQTT messages correctly, it looks like self.async_alarm_arm_home(code) self.async_alarm_arm_away(code) self.async_alarm_arm_night(code) self.async_alarm_disarm(code) functions are broken or are failing out for some reason. Code now required?

Originally posted here under wrong issue: https://github.com/akasma74/Hass-Custom-Alarm/issues/63#issuecomment-583553914

akasma74 commented 4 years ago

I've just updated to 0.105.2 and can reproduce it. Stay tuned..

e2m32 commented 4 years ago

You rock! Thanks for the fix 👍Just tested working in 0.105.2 😎

akasma74 commented 4 years ago

Glad it works for you but it's not all great :\

e2m32 commented 4 years ago

😧Bummer. Yeah, I tried testing the last version on my dev install that doesn't have mqtt setup and it failed. That manifest requires mqtt to be set up... and there is an import of the mqtt component (that used to be under an if statement, but it's commented out). Does there need to be two versions? Or can you get away with some kind of if statement for the manifest 🤔You had to add that to the manifest in the last version for it to work with 0.103.

akasma74 commented 4 years ago

looking into it, no for 2 versions ;)