search

akasma74 / Hass-Custom-Alarm

It is a fork of "Yet another take on a home assistant custom alarm" that will exist until its author is back to our Earth
80 stars 31 forks source link

Upgrading to version 1.12.2 causes two side menu items for component #86

Closed sparkydave1981 closed 4 years ago

sparkydave1981 commented 4 years ago

Your components (from Alarm/Settings/About):

Platform & Browser:

Describe the bug Version 1.12.2 of this component changes the side menu address to /custom-alarm. The old address was /alarm. Rather than replacing the old side menu item with the new address we now have two side menu items, giving both the old and new addresses, should only have the single side menu item with the new address

To Reproduce Steps to reproduce the behavior:

  1. Go to 'side menu in HA'
  2. You will see two 'Alarm' options (should only be one)

Expected behavior Should only be a single 'Alarm' menu item in the HA side menu.

Screenshots If applicable, add screenshots to help explain your problem. image

Additional context Both menu items appear to work, in that they both control the alarm component

suds32 commented 4 years ago

Same issue here

akasma74 commented 4 years ago

guys, could you try this release and let me know if it changes anything?

suds32 commented 4 years ago

No change for me - still has 2 alarm icons

sparkydave1981 commented 4 years ago

Upgraded to 1.12.3 and restarted HA, cleared cache in Chrome, still seeing two side menu items

akasma74 commented 4 years ago

ok, cool. Do you guys happen to have more than one device accessing your HA instance? Somethig like a tablet/mobile phone. Have you cleared cache/restarted them as well?

suds32 commented 4 years ago

Tried on pc iPad android phone. Restarted also tested using ha app

sparkydave1981 commented 4 years ago

I've tried on work PC (multiple Ctrl+F5's) and android app (cleared cache in app settings).

akasma74 commented 4 years ago

Ok, could you roll it back to v1.12.1 and see if it makes any difference? The trouble is I couldn't reproduce it with HA 0.106.6 and it works as expected with 0.107.5

suds32 commented 4 years ago

Rolled back to 1.12.1 all good with just the single alarm icon - /alarm Back to 1.12.3 and 2 icons /alarm and /custom-alarm

akasma74 commented 4 years ago

Can you guys tell me more about your environment? HA version, type of installation?

suds32 commented 4 years ago

Home Assistant 0.107.6 Supervisor Version 209

arch x86_64
dev false
docker true
hassio true
os_name Linux
os_version 5.3.0-40-generic
python_version 3.7.7
timezone Pacific/Auckland
version 0.107.6
virtualenv false

Hope that covers everything

sparkydave1981 commented 4 years ago

I'm still on HA 0.106.6 (will upgrade next week)

Host System Ubuntu 18.04.3 LTS Supervisor v209

arch x86_64
dev false
docker true
hassio true
os_name Linux
python_version 3.7.6
timezone Australia/Perth
version 0.106.6
virtualenv false
suds32 commented 4 years ago

just wondering if their was a resolution for this

akasma74 commented 4 years ago

well, it looks like a false alarm so the best course now is to roll back to v1.12.1 I'll clear up the code when I have time

akasma74 commented 4 years ago

resolved by v1.12.4 release